kruskal_algorithm problems #1 #12039

Anantbhardwaj2003 · 2024-10-13T17:41:33Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-14T04:50:08Z

genetic_algorithm/ga_optimisation.py

+import numpy as np
+
+class GeneticAlgorithm:
+    def __init__(self, func, bounds, pop_size=20, generations=100, mutation_rate=0.1, crossover_rate=0.8, selection_method='tournament'):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: func

Please provide type hint for the parameter: bounds

Please provide type hint for the parameter: pop_size

Please provide type hint for the parameter: generations

Please provide type hint for the parameter: mutation_rate

Please provide type hint for the parameter: crossover_rate

Please provide type hint for the parameter: selection_method

algorithms-keeper · 2024-10-14T04:50:08Z

genetic_algorithm/ga_optimisation.py

+        self.crossover_rate = crossover_rate
+        self.selection_method = selection_method
+
+    def initialize_population(self):


Please provide return type hint for the function: initialize_population. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/ga_optimisation.py, please provide doctest for the function initialize_population

algorithms-keeper · 2024-10-14T04:50:08Z

genetic_algorithm/ga_optimisation.py

+        dim = len(self.bounds)
+        return np.array([np.random.uniform(self.bounds[d][0], self.bounds[d][1], self.pop_size) for d in range(dim)]).T
+
+    def fitness(self, individual):


Please provide return type hint for the function: fitness. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/ga_optimisation.py, please provide doctest for the function fitness

Please provide type hint for the parameter: individual

algorithms-keeper · 2024-10-14T04:50:08Z

genetic_algorithm/ga_optimisation.py

+        # Calculate fitness (for minimization, return function value)
+        return self.func(*individual)
+
+    def selection(self, population, fitness_values):


Please provide return type hint for the function: selection. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/ga_optimisation.py, please provide doctest for the function selection

Please provide type hint for the parameter: population

Please provide type hint for the parameter: fitness_values

algorithms-keeper · 2024-10-14T04:50:09Z

genetic_algorithm/ga_optimisation.py

+        elif self.selection_method == 'roulette':
+            return self.roulette_wheel_selection(population, fitness_values)
+
+    def tournament_selection(self, population, fitness_values):


Please provide return type hint for the function: tournament_selection. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file genetic_algorithm/ga_optimisation.py, please provide doctest for the function tournament_selection

Please provide type hint for the parameter: population

Please provide type hint for the parameter: fitness_values

algorithms-keeper · 2024-10-14T04:50:09Z

graphs/kruskal_algo.py

@@ -0,0 +1,51 @@
+class DisjointSet:
+    def __init__(self, n):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: n

Please provide descriptive name for the parameter: n

algorithms-keeper · 2024-10-14T04:50:09Z

graphs/kruskal_algo.py

+        self.parent = list(range(n))
+        self.rank = [0] * n
+
+    def find(self, u):


Please provide return type hint for the function: find. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file graphs/kruskal_algo.py, please provide doctest for the function find

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

algorithms-keeper · 2024-10-14T04:50:09Z

graphs/kruskal_algo.py

+            self.parent[u] = self.find(self.parent[u])
+        return self.parent[u]
+
+    def union(self, u, v):


Please provide return type hint for the function: union. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file graphs/kruskal_algo.py, please provide doctest for the function union

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: u

Please provide type hint for the parameter: v

Please provide descriptive name for the parameter: v

algorithms-keeper · 2024-10-14T04:50:09Z

graphs/kruskal_algo.py

+                self.rank[root_u] += 1
+
+
+def kruskal_algorithm(vertices, edges):


Please provide return type hint for the function: kruskal_algorithm. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file graphs/kruskal_algo.py, please provide doctest for the function kruskal_algorithm

Please provide type hint for the parameter: vertices

Please provide type hint for the parameter: edges

algorithms-keeper · 2024-10-14T04:50:10Z

graphs/kruskal_algo.py

+
+def kruskal_algorithm(vertices, edges):
+    # Step 1: Sort edges based on weight
+    edges.sort(key=lambda x: x[2])


Please provide descriptive name for the parameter: x

for more information, see https://pre-commit.ci

cclauss · 2024-10-22T09:27:41Z

Closing require_type_hints PRs to prepare for Hacktoberfest

Anantbhardwaj2003 and others added 2 commits October 13, 2024 23:04

kruskal_alog is coded

acf4baf

[pre-commit.ci] auto fixes from pre-commit.com hooks

04c83ef

for more information, see https://pre-commit.ci

algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 13, 2024

Genetic Algorithm for Function Optimization TheAlgorithms#11578 updated

6ef905b

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 14, 2024

algorithms-keeper bot reviewed Oct 14, 2024

View reviewed changes

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 14, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

8e4aa44

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 14, 2024

cclauss closed this Oct 22, 2024

		self.rank[root_u] += 1


		def kruskal_algorithm(vertices, edges):

Uh oh!

kruskal_algorithm problems #1 #12039

kruskal_algorithm problems #1 #12039

Uh oh!

Conversation

Anantbhardwaj2003 commented Oct 13, 2024

Describe your change:

Checklist:

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

cclauss commented Oct 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants