Skip to content

hey i made some changes in this project hope that you would like #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhon3180
Copy link

@jhon3180 jhon3180 commented Aug 7, 2025

Because

This PR

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, I have ensured that the TOP solution files match the Desired Outcome image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jhon3180, thanks for taking the time to make a contribution!

However, this PR doesn't follow the contribution guidelines and edits a solution that already works as intended. It also introduces structural issues, such as malformed HTML (e.g., incorrect use of <div id="Hit the button">).

Please avoid making unnecessary changes to working solutions, and consider using your own forked repository if you're experimenting or practicing.

This PR appears to be incomplete and not relevant to the project's needs.

@maintainers, please feel free to close it.

Best of luck on your web development journey, @jhon3180!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants