Skip to content

hey i made some changes in this project hope that you would like #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hey i made some changes in this project hope that you would like #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions advanced-html-css/animation/01-button-hover/solution/solution.html
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jhon3180, thanks for taking the time to make a contribution!

However, this PR doesn't follow the contribution guidelines and edits a solution that already works as intended. It also introduces structural issues, such as malformed HTML (e.g., incorrect use of <div id="Hit the button">).

Please avoid making unnecessary changes to working solutions, and consider using your own forked repository if you're experimenting or practicing.

This PR appears to be incomplete and not relevant to the project's needs.

@maintainers, please feel free to close it.

Best of luck on your web development journey, @jhon3180!

Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
<link rel="stylesheet" href="solution.css" />
</head>
<body>
<div id="transition-container">
<button>Transition!</button>
<div id="Hit the button">
<button>Hit the Button!!</button>
</div>
</body>
</html>