refactor: add getByteCount() method to NetChatCommandMsg and use it

Author: bobtista

GeneralsMD/Code/GameEngine/Include/GameNetwork/NetCommandMsg.h

@@ -328,6 +328,8 @@ class NetChatCommandMsg : public NetCommandMsg
 	Int getPlayerMask( void );
 	void setPlayerMask( Int playerMask );
 
+	size_t getByteCount() const;
+
 protected:
 	UnicodeString m_text;
 	Int m_playerMask;

GeneralsMD/Code/GameEngine/Source/GameNetwork/NetCommandMsg.cpp

@@ -759,6 +759,14 @@ void NetChatCommandMsg::setPlayerMask( Int playerMask )
 	m_playerMask = playerMask;
 }
 
+/**
+ * Get the byte count for this chat message.
+ */
+size_t NetChatCommandMsg::getByteCount() const
+{
+	return m_text.getLength() * sizeof(UnsignedShort) + sizeof(m_playerMask);
+}
+
 //-------------------------
 // NetDisconnectVoteCommandMsg
 //-------------------------

GeneralsMD/Code/GameEngine/Source/GameNetwork/NetPacket.cpp

@@ -476,8 +476,7 @@ UnsignedInt NetPacket::GetDisconnectVoteCommandSize(NetCommandMsg *msg) {
 
 UnsignedInt NetPacket::GetChatCommandSize(NetCommandMsg *msg) {
 	NetChatCommandMsg *cmdMsg = static_cast<NetChatCommandMsg*>(msg);
-	UnsignedByte textmsglen = cmdMsg->getText().getLength();
-	return sizeof(NetPacketChatCommandHeader) + (textmsglen * sizeof(UnsignedShort)) + sizeof(Int);
+	return sizeof(NetPacketChatCommandHeader) + cmdMsg->getByteCount();
 }
 
 UnsignedInt NetPacket::GetProgressMessageSize(NetCommandMsg *msg) {