[GEN][ZH] Remove RTS_INTERNAL

[xezon]

Merge with Rebase

• Resolves Remove RTS_INTERNAL #1176

This change removes RTS_INTERNAL. It is mostly done by script. The commits are split into reviewable chunks.

[barefootlogician]

idk if it would be better as a separate pr or as part of this one but there's a lot of files with commented out pragma optimize code that used the RTS_INTERNAL macro that can probably also be removed

[xezon]

idk if it would be better as a separate pr or as part of this one but there's a lot of files with commented out pragma optimize code that used the RTS_INTERNAL macro that can probably also be removed

Yes that is removed with this change.

[barefootlogician]

idk if it would be better as a separate pr or as part of this one but there's a lot of files with commented out pragma optimize code that used the RTS_INTERNAL macro that can probably also be removed

Yes that is removed with this change.

Awesome!

[Skyaero42]

Because of the size, it will take some time to review this

[xezon]

Much respect if you look at all lines. I trusted the script for the most part :)

[barefootlogician]

So if I'm looking at this correctly this is how the commits break down (not in order)

1] The first commit is exclusively for removes only the already commented out pragma optimize code so we can just mark that off as good

2] The second commit deals exclusively with instances where the condition is something form ±RTS_DEBUG and/or ±RTS_INTERNAL so we just need to double check that all the variations and their replacements were correct which they probably are

5] The fifth is just adding the python script that was used and doesn't do any functional changes itself but is relevant for review just to check/understand the other commits so unless there's something wrong with the other commits this one can be assumed good by default

4] The fourth is just removing rts_interal from cmake presets and .cmake files which is pretty straightforward and should be good but I will double check just in case

6,7] The sixth and seventh commits are just updates to the third

3] This leaves mainly just the third commit left that needs to be reviewed carefully

[ghost]

I'm guessing based on this PR, that I should go ahead and remove any mention of the internal build profile on the wiki?

[xezon]

Yea after this is merged, RTS_INTERNAL is gone, because it essentially was duplicate of RTS_DEBUG.

[ghost]

I have a PR for the Wiki lined up for when this PR gets merged: TheSuperHackers/GeneralsWiki#55

[Skyaero42]

Much respect if you look at all lines. I trusted the script for the most part :)

Yes, I'm reviewing all lines.

[xezon]

Addressed review comments.

[xezon]

All new review comments addressed.

[barefootlogician]

would you mind rebasing the fix up commits so that its easier to review the net changes