[GEN][ZH] Fix Hero Radar icon garrison issues introduced by #1035

[xezon]

• Fixes Hero icon in garrison is bugged #1246
• Follow up for [GEN][ZH] Fix Hero Radar issues introduced by #1035 #1240
• Follow up for [GEN][ZH] Fix heap-use-after-free in W3DRadar::drawHeroIcon() #1035

This change fixes #1246, which was introduced with #1035 and #1240. There were actually 3 bugs remaining:

1. Hero Radar icons on garrisoned building were not removed or updated from the Radar
2. Hero Radar icons would stack inside garrisons
3. Hero Radar icons would move to fire ports when shooting, which looked irritating

To fix that, I reinstanted the "calcHero" code that the original EA code had, in combination with code that takes care of cleaning up the object pointers to avoid dangling.

---

I did experiment with several implementations and there are many pitfalls when doing it just not the right way. I tried removing and adding Geros and Buildings containing Heros on containing and uncontaining, but that was doomed with Saveload, because after Load the order of containment is not favourable for this to work.

TODO

• Replicate in Generals

[Caball009]

This fixes a crash for me probably introduced by the recent changes to the hero radar.

I tried to load a save game from a couple of weeks ago and got a crash here because m_containListSize was 1, but the list itself was empty:

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Contain/OverlordContain.cpp

Lines 181 to 190 in 106f217

	// If I am empty, say no.
	if( m_containListSize < 1 )
	return NULL;
	if( !m_redirectionActivated )
	return NULL;// Shut off early to allow death to happen without my bunker having
	// trouble finding me to say goodbye as messages get sucked up the pipe to him.
	Object *myGuy = m_containList.front();
	if( myGuy )

Callstack:

generalszh.exe!std::list<Object *,std::allocator<Object *>>::front() Line 1220
generalszh.exe!OverlordContain::getRedirectedContain() Line 189
generalszh.exe!OverlordContain::iterateContained(void(*)(Object *, void *) func, void * userData, bool reverse) Line 350
generalszh.exe!Object::isHero() Line 2037
generalszh.exe!W3DRadar::onLocalRadarObjectAdded(const RadarObject * radarObject) Line 1458
generalszh.exe!W3DRadar::rebuildCachedHeroObjectList() Line 1484
generalszh.exe!W3DRadar::xfer(Xfer * xfer) Line 856

[Mauller]

Looks good

[xezon]

Replicated to Generals without conflicts.