Skip to content

fix(exploit): fix group force attack exploit when a building group is added to a unit selection #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roossienb
Copy link

@roossienb roossienb commented Jul 23, 2025

While EA fixed the group force attack exploit ("scud bug") when one was trying to add a building to a group with units, it was still possible to do the reverse: Add the building to a group. Select a bunch of units and than add-select ('shift') the group to the current selection.

To remedy this, every object in the group needs to be checked for kindof building when getting added to an existing selection.

@roossienb roossienb added this to the Code foundation build up milestone Jul 23, 2025
@roossienb roossienb self-assigned this Jul 23, 2025
@roossienb roossienb added Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Fix Is fixing something, but is not user facing labels Jul 23, 2025
@roossienb roossienb changed the title Fix group force attack exploit when a building group is added to a unit selection [Gen][ZH] Fix group force attack exploit when a building group is added to a unit selection Jul 23, 2025
@roossienb roossienb force-pushed the fix-scud-bug-through-add-group branch from 309d7b8 to c5297f7 Compare July 23, 2025 12:53
@roossienb roossienb changed the title [Gen][ZH] Fix group force attack exploit when a building group is added to a unit selection [GEN][ZH] Fix group force attack exploit when a building group is added to a unit selection Jul 23, 2025
@roossienb roossienb force-pushed the fix-scud-bug-through-add-group branch from c5297f7 to 987fcc2 Compare July 23, 2025 12:57
@roossienb roossienb force-pushed the fix-scud-bug-through-add-group branch from 987fcc2 to 58a39bd Compare July 24, 2025 19:17
@roossienb
Copy link
Author

roossienb commented Jul 24, 2025

Removed the dependency and have taken the logic out of the for-loop.
Behaviour is now also in line with gentool

@roossienb roossienb changed the title [GEN][ZH] Fix group force attack exploit when a building group is added to a unit selection fix(exploit: fix group force attack exploit when a building group is added to a unit selection Jul 26, 2025
@Caball009 Caball009 changed the title fix(exploit: fix group force attack exploit when a building group is added to a unit selection fix(exploit): fix group force attack exploit when a building group is added to a unit selection Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Is fixing something, but is not user facing Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Units and Buildings can be grouped together by using the SHIFT key feature
2 participants