bugfix(controls): Fix double-press group selection logic not reselecting deselected groups #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
reviewed
Jul 26, 2025
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
Stubbjax
force-pushed
the
fix-double-press-group-selection
branch
from
6d89917 to
27583db
Compare
xezon
reviewed
Aug 1, 2025
xezon
changed the title
xezon
changed the title
xezon
added
Minor
Caball009
reviewed
Aug 1, 2025
Generals/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Show resolved
Hide resolved
xezon
reviewed
Aug 2, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Show resolved
Hide resolved
xezon
reviewed
Aug 2, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp
Outdated
Show resolved
Hide resolved
Stubbjax
force-pushed
the
fix-double-press-group-selection
branch
from
7b445be to
8143cc5
Compare
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ing deselected groups (TheSuperHackers#1355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Centering the camera on a group does not (re)select the group #1332
Alternative solution to [GEN][ZH] Fix reselection of group not always working #1334
Centering the camera on a group by double-pressing a group selection hotkey (0 - 9) will now reselect the group if it was deselected.
Technically either one of the two commits fixes the issue. Setting
m_lastGroupSelGroup = -1;on global deselect is essentially replicating the existing behaviour of selecting something else (where the last group is also set to -1) - which also allows the group to be selected again - whereas theperformSelectionlogic adjustment acts as more of a safer catch-all in case the selection can be lost by other means.