bugfix(debug): Fix memory corruption in DebugCrash() #1371
Merged
+32
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Blocker
xezon
force-pushed
the
xezon/fix-debug-crash
branch
from
21188b2 to
43bdd9c
Compare
xezon
added
Critical
Caball009
reviewed
Jul 27, 2025
Caball009
approved these changes
Jul 27, 2025
|
In a follow up we can make the zero write in vsnprintf in stdio_adapter.h conditional. |
xezon
force-pushed
the
xezon/fix-debug-crash
branch
from
43bdd9c to
5e5c9e6
Compare
xezon
added a commit
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change fixes the memory corruption in DebugCrash().
It has 2 commits. The first is the bug fix. The second is fixing a few more theoretical offenders in Debug.cpp.
The corruption was introduced by #1275 and only manifested as a runtime issue in VC6 Debug because of #858.