Skip to content

build(debug): Fix GeneralsMD debug compile error when logging is turned off#1372

Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/fix-debug-compile-error
Jul 28, 2025
Merged

build(debug): Fix GeneralsMD debug compile error when logging is turned off#1372
xezon merged 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/fix-debug-compile-error

Conversation

@xezon
Copy link

@xezon xezon commented Jul 27, 2025

This change fixes a debug compile error when logging is turned off. Only happens with Zero Hour. Generals somehow already has the correct #ifdef.

GeneralsMD\Code\GameEngine\Source\GameLogic\AI\AISkirmishPlayer.cpp(813) : error C4101: 'to' : unreferenced local variable

@xezon xezon added this to the Code foundation build up milestone Jul 27, 2025
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker CompileBug Bug at compile time Debug Is mostly debug functionality labels Jul 27, 2025
Copy link

@helmutbuhler helmutbuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xezon xezon merged commit 567e600 into TheSuperHackers:main Jul 28, 2025
9 checks passed
@xezon xezon deleted the xezon/fix-debug-compile-error branch July 28, 2025 15:59
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CompileBug Bug at compile time Debug Is mostly debug functionality Minor Severity: Minor < Major < Critical < Blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants