refactor(debug): Rename and simplify GetAsciiNetCommandType()#1377
Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom Jul 30, 2025
Merged
refactor(debug): Rename and simplify GetAsciiNetCommandType()#1377xezon merged 1 commit intoTheSuperHackers:mainfrom
xezon merged 1 commit intoTheSuperHackers:mainfrom
Conversation
Mauller
added
Minor
xezon
changed the title
xezon
approved these changes
Jul 28, 2025
OmniBlade
approved these changes
Jul 29, 2025
…String and internally change it to use a switch and to return c strings
Mauller
force-pushed
the
refactor-getnetcommandasstring
branch
from
6f6f640 to
e28d7b6
Compare
Author
|
Added debug crash to default case, should be good now. |
xezon
approved these changes
Jul 30, 2025
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…erHackers#1377) Renamed to GetNetCommandTypeAsString(). Now uses a switch and returns C strings for efficiency.
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…erHackers#1377) Renamed to GetNetCommandTypeAsString(). Now uses a switch and returns C strings for efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors a function to optimise it's internal behaviour and to return c strings instead of ascii strings.
The function internally allocated ascii strings for them to be turned back into c strings externally.
It also used a block of
if else ifstatements to check and return the relevant string.This was refactored to instead return c strings and to use a switch internally.
I also re-ordered the case statements to match the ordering of the enumeration the values belong to.