tweak(recorder): Improve performance of Replay playback slightly by increasing the Replay file read buffer to 8192 bytes#1389
Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom Aug 13, 2025
Conversation
Mauller
added
Enhancement
Mauller
force-pushed
the
tweak-recorder-buffer-size
branch
from
0609758 to
69f67cb
Compare
tintinhamans
changed the title
Mauller
force-pushed
the
tweak-recorder-buffer-size
branch
from
69f67cb to
5bc5ef0
Compare
Author
|
This was just rebased to catch up to changes on the recorder class and main, can be looked at after recorder is done |
Mauller
force-pushed
the
tweak-recorder-buffer-size
branch
2 times, most recently
from
4672610 to
6a94ea8
Compare
Author
|
This should be good now and ready to merge. |
xezon
reviewed
Aug 10, 2025
Mauller
force-pushed
the
tweak-recorder-buffer-size
branch
from
6a94ea8 to
4f84de0
Compare
Author
|
Tweaked and pushed. |
xezon
approved these changes
Aug 10, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Looks good.
What is the measured performance improvement now?
Author
During an ingame replay it is not that large, probably around 5-10 seconds over a 4 minute replay. |
xezon
changed the title
xezon
added
Performance
|
Updated title. |
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ncreasing the Replay file read buffer to 8192 bytes (TheSuperHackers#1389) Replay playback was measured to be about 3% faster
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…ncreasing the Replay file read buffer to 8192 bytes (TheSuperHackers#1389) Replay playback was measured to be about 3% faster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how replay files are opened so they open with a larger than standard file buffer.
This is to help reduce disk access and aid replay playback speed in the long run.
As other bottlenecks are removed in the future, this PR should present a biffer performance boost.