fix(cpudetect): Fix version and memory detection #1393
Conversation
OmniBlade
requested review from
a team,
Mauller,
Skyaero42,
barefootlogician,
helmutbuhler,
tomsons26 and
xezon
barefootlogician
left a comment
barefootlogician
left a comment
There was a problem hiding this comment.
currently the max specs it checks are such that pretty much any pc we would use today would more than quilify for the highest preset. I'd just replace everything with stubs that return the highest result and later refactor all the places where the stub functions are called.
xezon
changed the title
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Just some minor things. Otherwise, looks good.
Memory detection would be incorrect on systems with > 4GB. Verson info detection is incorrect on Windows 8 and later and if manifested for an earlier version than currently running on.
OmniBlade
force-pushed
the
fix/cpudetect_deprecation
branch
from
7eb4130 to
213447f
Compare
The info cpudetect returns isn't just used for check in the game itself, is also used for outputting system information in the debug log and crash report if I remember rightly. |
xezon
added
Minor
xezon
changed the title
xezon
changed the title
Memory detection was incorrect on systems with > 4GB. Version info detection was incorrect on Windows 8 and later and if manifested for an earlier version than currently running on.
3 participants
Memory detection would be incorrect on systems with > 4GB. Verson info detection is incorrect on Windows 8 and later and if manifested for an earlier version than currently running on.