unify(dx8wrapper): Migrate dx8wrapper.cpp and h to the core WW3D2 folder

[ryan-de-boer]

The core dx8wrapper is now the ZH one, and generals code has been changed to work with it.

[Mauller]

This is actually really difficult to follow because of how it has been performed.

Because of the number of files and nature of this part of the code, it would have been better to first unify the differences between the files from the two games. Then look at extracting commonality and moving to core.

Right now entire chunks are moved about making it difficult to read the changes that were possibly made or overlooked between the two versions.

[xezon]

This is a good initiative. We need to get ww3d2 unified. Would it be possible to breakdown what features and fixes Generals inherited?

Unification changes going to main branch definitely need at least 2 commits:

• First for merging code
• Second for moving files to Core

I would not mind merging code in small steps if that makes reviewing easier, given the complexity of the diff. Would that be feasible to do with dx8wrapper?

[ryan-de-boer]

Thanks for your comment xezon. I'll try to make shorter pull requests and try to make reviewing easier. Not even moving files until the two duplicate dx8wrapper.cpp/h files are identical and pull request approved first.

[xezon]

That sounds lovely.

As for moving files to Core, I have created a helper script here that makes it easy: #1398

[xezon]

Do we want to close this pull in the meantime?

[ryan-de-boer]

Closing this pull request, as I have started again with this smaller pull request:
#1423