Skip to content

chore: Add .editorconfig to set default whitespacing rules#1415

Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/add-editorconfig
Aug 8, 2025
Merged

chore: Add .editorconfig to set default whitespacing rules#1415
xezon merged 1 commit intoTheSuperHackers:mainfrom
xezon:xezon/add-editorconfig

Conversation

@xezon
Copy link

@xezon xezon commented Aug 3, 2025

This change adds a .editorconfig file to set default whitespacing rules.

@xezon xezon added the Build Anything related to building, compiling label Aug 3, 2025
@xezon
Copy link
Author

xezon commented Aug 5, 2025

I noticed that the trim_trailing_whitespace = true will remove not just whitespaces in the new lines written, but in all lines on document save (depending on the editor). So I think we would need to make a pass and remove all trailing whitespace first, to not get into situations where new changes edit unrelated whitespaces in a file.

@xezon
Copy link
Author

xezon commented Aug 5, 2025

Ok I have prepared a change that removes trailing spacespace: #1425

It is quite a massive change...

@xezon xezon force-pushed the xezon/add-editorconfig branch from a7e8818 to 69cf2a6 Compare August 6, 2025 22:19
@xezon
Copy link
Author

xezon commented Aug 6, 2025

Whitespace fixes merged to main branch. Rebased. I will test once more if behavior is ok now.

@xezon
Copy link
Author

xezon commented Aug 7, 2025

The "trim_trailing_whitespace" works in Visual Studio Code, but appears to not work in Visual Studio 2022. But I guess it is ok for now.

@xezon xezon merged commit e6ee245 into TheSuperHackers:main Aug 8, 2025
6 checks passed
@xezon xezon deleted the xezon/add-editorconfig branch August 8, 2025 17:27
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Anything related to building, compiling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants