bugfix(input): No longer require two clicks to deselect worker after cancelling building placement in alternate mouse mode#1453
Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom Aug 14, 2025
Conversation
…ing building placement in alternate mouse mode
xezon
added
Bug
xezon
changed the title
xezon
approved these changes
Aug 14, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…cancelling building placement in alternate mouse mode (TheSuperHackers#1453)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…cancelling building placement in alternate mouse mode (TheSuperHackers#1453)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1447
Follow-up to #1430
This change disables the "set prevention of left click deselection in alternate mouse mode for one click" logic when cancelling building placement - a leftover side-effect from the improvement introduced with #1430.
The respective
setPreventLeftClickDeselectionInAlternateMouseModeForOneClickmethod is used to prevent a worker from being deselected when placing a structure, which is considered a click on empty terrain that would otherwise deselect the unit. In this case, as building placement has been cancelled, it is set back to false so that clicking an empty area will deselect the worker as expected.