bugfix: Singular right-click logic now always executes after a double right-click #1454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes single right-click behaviour not being performed on a double right-click.
When a double right-click is performed, the singular right-click logic is potentially not executed as the
isClick
condition may return false. This is due to the double-click logic not updating the mouse down and mouse up timestamps that determine whether the user is holding down the mouse button (for camera dragging purposes). This means that there is a brief window after cancelling a context command (unit abilities, Beacon placement, General's Powers, etc.) that a unit will not perform the respective right-click action on the second right-click.Note: Double-clicking very fast will cause the double-click to be within the first click's timestamp window and
isClick
will thus succeed. The issue is most noticeable when exiting context modes via a 'slower' double right-click.