unify(object): Merge the unit veterancy effect changes including the veterancy effect fix for detected stealth units from Zero Hour

[Stubbjax]

This change ports the provideFeedback parameter and respective logic regarding the veterancy effect from Zero Hour to Generals. It also fixes a bug in Generals where detected stealth units would not play the veterancy effect.

[xezon]

Is this meant to be merged with Rebase?

Edit:

1. Most of commits 2 & 3 look to be a unify change.

2. Then the remainder of 1 & 2 are the bugfix.

3. And then 4 & 5 are the optimization/refactor.

I suggest create 3 Pull for these that build on top of each other, in that order.

[xezon]

This can be simplified more:

Set provideFeedback = FALSE in case LEVEL_REGULAR

Then move this code up here to down below:

if( provideFeedback && TheGameLogic->getDrawIconUI() )
{
  Bool hideAnimationForStealth = !isLocallyControlled() &&
				testStatus( OBJECT_STATUS_STEALTHED ) &&
				!testStatus( OBJECT_STATUS_DETECTED ) &&
				!testStatus( OBJECT_STATUS_DISGUISED );

  Bool doAnimation = ( ! hideAnimationForStealth
									&& (newLevel > oldLevel)
									&& ( ! isKindOf(KINDOF_IGNORED_IN_GUI))); //First, we plan to do the animation if the level went up

  if ( doAnimation )
  {
    ...
  }
}

[Stubbjax]

I suggest create 3 Pull for these that build on top of each other, in that order.

Updated!

[xezon]

Title updated.

[xezon]

Is this meant to be merged with rebase? If yes then the commit titles need updating.

[Stubbjax]

Is this meant to be merged with rebase? If yes then the commit titles need updating.

I had not intended it to be. If that is preferable, what titles do you suggest?

[xezon]

unify(object): Merge the condition switch for the unit veterancy effect from Zero Hour (#1455)
unify(object): Merge the missing veterancy effect fix for detected stealth units from Zero Hour (#1455)

[Stubbjax]

unify(object): Merge the condition switch for the unit veterancy effect from Zero Hour (#1455)
unify(object): Merge the missing veterancy effect fix for detected stealth units from Zero Hour (#1455)

Done.