tweak(input): Remove input latency for group creation in multiplayer games

[Stubbjax]

The local player no longer has to wait for their group assignment commands to be processed by GameLogicDispatch, which is typically 10 - 64 logic frames after sending the command in multiplayer games. They are instead now immediately processed by CommandXlat for the local player.

This change makes gameplay feel smoother and more responsive. It has no effect on the synchronicity of multiplayer games.

[xezon]

I am skeptical of this change because it splits the same kind of call into 2 places.

[xezon]

Can we do disp = DESTROY_MESSAGE; here to avoid the dependency test in GameLogicDispatch?

[Stubbjax]

Would this not prevent the message from being dispatched to other players?

[xezon]

I did not check.

[Stubbjax]

I am skeptical of this change because it splits the same kind of call into 2 places.

This is the same pattern used everywhere else across the message translators.

[xezon]

This is the same pattern used everywhere else across the message translators.

Ok. Can you please list one comparable example?

[Stubbjax]

This is the same pattern used everywhere else across the message translators.

Ok. Can you please list one comparable example?

Simply selecting units (MSG_CREATE_SELECTED_GROUP) happens immediately for the client but is also sent across the network to other players.

Below are the commands that are processed in both CommandXlat and GameLogicDispatch. A lot of them are processed locally in CommandXlat for immediate feedback purposes (e.g. unit voices, UI state) before being logically actioned in GameLogicDispatch.

MSG_ADD_TEAM0
MSG_ADD_TEAM1
MSG_ADD_TEAM2
MSG_ADD_TEAM3
MSG_ADD_TEAM4
MSG_ADD_TEAM5
MSG_ADD_TEAM6
MSG_ADD_TEAM7
MSG_ADD_TEAM8
MSG_ADD_TEAM9
MSG_COMBATDROP_AT_LOCATION
MSG_COMBATDROP_AT_OBJECT
MSG_CREATE_SELECTED_GROUP
MSG_CREATE_SELECTED_GROUP_NO_SOUND
MSG_DESTROY_SELECTED_GROUP
MSG_DOCK
MSG_DOZER_CONSTRUCT
MSG_DOZER_CONSTRUCT_LINE
MSG_DO_ATTACKMOVETO
MSG_DO_ATTACK_OBJECT
MSG_DO_FORCE_ATTACK_GROUND
MSG_DO_FORCE_ATTACK_OBJECT
MSG_DO_GUARD_OBJECT
MSG_DO_GUARD_POSITION
MSG_DO_MOVETO
MSG_DO_REPAIR
MSG_DO_SALVAGE
MSG_DO_SPECIAL_POWER
MSG_DO_SPECIAL_POWER_AT_LOCATION
MSG_DO_SPECIAL_POWER_AT_OBJECT
MSG_DO_WEAPON_AT_LOCATION
MSG_DO_WEAPON_AT_OBJECT
MSG_ENTER
MSG_EVACUATE
MSG_GET_HEALED
MSG_GET_REPAIRED
MSG_INTERNET_HACK
MSG_LOGIC_CRC
MSG_PICK_UP_PRISONER
MSG_RESUME_CONSTRUCTION
MSG_SELECT_TEAM0
MSG_SELECT_TEAM1
MSG_SELECT_TEAM2
MSG_SELECT_TEAM3
MSG_SELECT_TEAM4
MSG_SELECT_TEAM5
MSG_SELECT_TEAM6
MSG_SELECT_TEAM7
MSG_SELECT_TEAM8
MSG_SELECT_TEAM9
MSG_SET_REPLAY_CAMERA
MSG_SWITCH_WEAPONS

[xezon]

If it works, then all good.