tweak(menu): Show mouse and menu immediately when shellmap is disabled#1480
Merged
xezon merged 4 commits intoTheSuperHackers:mainfrom Aug 22, 2025
Merged
Conversation
11c9978 to
5273462
Compare
xezon
approved these changes
Aug 20, 2025
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/MainMenu.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/MainMenu.cpp
Outdated
Show resolved
Hide resolved
By default, the cursor and menu are hidden to display the shell map. When using the `--quickstart` option, the shell map is replaced with a static background, but the player still had to move the mouse before the cursor and menu appeared. This change explicitly checks if the shell map is enabled, ensuring the mouse and menu are shown immediately when it is not.
5273462 to
5f76fc0
Compare
Stubbjax
reviewed
Aug 21, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/MainMenu.cpp
Outdated
Show resolved
Hide resolved
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/MainMenu.cpp
Outdated
Show resolved
Hide resolved
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/MainMenu.cpp
Outdated
Show resolved
Hide resolved
…Menus/MainMenu.cpp Co-authored-by: Stubbjax <stubbjax02@hotmail.com>
…nus/MainMenu.cpp Co-authored-by: Stubbjax <stubbjax02@hotmail.com>
…Menus/MainMenu.cpp Co-authored-by: Stubbjax <stubbjax02@hotmail.com>
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, the cursor and menu are hidden to display the shell map. When using the
--quickstartoption, the shell map is replaced with a static background, but the player still had to move the mouse before the cursor and menu appeared.This change explicitly checks if the shell map is enabled, ensuring the mouse and menu are shown immediately when it is not.