Skip to content

tweak: Disable test asset loading in release builds#1485

Merged
xezon merged 2 commits intoTheSuperHackers:mainfrom
xezon:xezon/disable-test-assets
Aug 26, 2025
Merged

tweak: Disable test asset loading in release builds#1485
xezon merged 2 commits intoTheSuperHackers:mainfrom
xezon:xezon/disable-test-assets

Conversation

@xezon
Copy link

@xezon xezon commented Aug 23, 2025

This change disables test asset loading in Release builds and fixes the compile error because of it.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Debug Is mostly debug functionality labels Aug 23, 2025
@xezon xezon force-pushed the xezon/disable-test-assets branch from 91acdc8 to cb31968 Compare August 24, 2025 09:47
@xezon
Copy link
Author

xezon commented Aug 24, 2025

Fixed compile error in World Builder.

@Mauller
Copy link

Mauller commented Aug 26, 2025

Are the test assets useful in world builder?

since this change looks like it would restrict worldbuilder from making use of them when running in a release build.

@xezon
Copy link
Author

xezon commented Aug 26, 2025

It is a test asset, so probably is not essential for World Builder to work. If Debug features are needed, then we run World Builder with Debug features.

Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookgs good to me

@xezon xezon changed the title tweak: Disable test asset loading in Release builds tweak: Disable test asset loading in release builds Aug 26, 2025
@xezon xezon merged commit a34fd16 into TheSuperHackers:main Aug 26, 2025
18 checks passed
@xezon xezon deleted the xezon/disable-test-assets branch August 26, 2025 19:18
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Debug Is mostly debug functionality Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants