tweak: Disable test asset loading in release builds#1485
Merged
xezon merged 2 commits intoTheSuperHackers:mainfrom Aug 26, 2025
Merged
tweak: Disable test asset loading in release builds#1485xezon merged 2 commits intoTheSuperHackers:mainfrom
xezon merged 2 commits intoTheSuperHackers:mainfrom
Conversation
91acdc8 to
cb31968
Compare
Author
|
Fixed compile error in World Builder. |
|
Are the test assets useful in world builder? since this change looks like it would restrict worldbuilder from making use of them when running in a release build. |
Author
|
It is a test asset, so probably is not essential for World Builder to work. If Debug features are needed, then we run World Builder with Debug features. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change disables test asset loading in Release builds and fixes the compile error because of it.