tweak(controlbar): Show stealthed radar objects to observers#1487
Merged
xezon merged 3 commits intoTheSuperHackers:mainfrom Sep 1, 2025
Merged
tweak(controlbar): Show stealthed radar objects to observers#1487xezon merged 3 commits intoTheSuperHackers:mainfrom
xezon merged 3 commits intoTheSuperHackers:mainfrom
Conversation
Stubbjax
added
Enhancement
xezon
reviewed
Sep 1, 2025
Generals/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp
Outdated
Show resolved
Hide resolved
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
This change allows observers to see stealthed enemy units on the radar.
While globally observing: All stealthed units are shown on the radar
While observing a specific player: Only stealthed units that the selected player can see are displayed on the radar
In the retail build, only the relationship of the current (and observing) player is considered, causing enemy stealthed units to never show on the radar for observers, while allies' stealthed units always do. In replays, stealthed units are always displayed on the radar and selecting a player makes no difference.