fix(filesystem): Decouple File System from NameKeyGenerator and its CRC influence#1516
Merged
xezon merged 3 commits intoTheSuperHackers:mainfrom Sep 4, 2025
Merged
Conversation
xezon
added
Major
Author
|
This was pain... |
2 tasks
Author
|
Generals is not compiling before replicating. |
Mauller
reviewed
Sep 1, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/GlobalLanguage.cpp
Outdated
Show resolved
Hide resolved
xezon
force-pushed
the
xezon/decouple-filesystem-from-crc
branch
from
4e8f0bf to
8b30d8f
Compare
Author
|
Replicated in Generals. |
xezon
force-pushed
the
xezon/decouple-filesystem-from-crc
branch
from
2b1b9f0 to
21de822
Compare
xezon
force-pushed
the
xezon/decouple-filesystem-from-crc
branch
from
21de822 to
a83350a
Compare
xezon
force-pushed
the
xezon/decouple-filesystem-from-crc
branch
from
a83350a to
75a26a4
Compare
Author
|
I can confirm that this now also fixes the CRC mismatch in Generals. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change decouples the File System from the NameKeyGenerator and its CRC influence. There are Name Key(s) somewhere used for CRC'ing and the File Existence Cache in File System influences the Name Keys on Engine Init.
I replaced the File Existence Map and preserved the 3 critical Name Keys for retail compatibility.
TODO