tweak(tree): Decouple tree sway, topple and sink time step from render update#1652
Merged
xezon merged 4 commits intoTheSuperHackers:mainfrom Oct 15, 2025
Merged
Conversation
xezon
added
Enhancement
Mauller
reviewed
Sep 30, 2025
GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DTreeBuffer.cpp
Outdated
Show resolved
Hide resolved
xezon
force-pushed
the
xezon/rendering-3-tree-updates
branch
from
38d536d to
4e24452
Compare
xezon
force-pushed
the
xezon/rendering-3-tree-updates
branch
from
4e24452 to
25727a1
Compare
Author
|
Updated. |
xezon
force-pushed
the
xezon/rendering-3-tree-updates
branch
from
25727a1 to
210e8f9
Compare
Author
|
Replicated SwayClientUpdate in Generals without conflicts. Things in W3DTreeBuffer not replicated because Generals version of it is old. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change decouples tree sway, topple and sink time step from render update.
Note that there are 2 kinds of trees:
Only optimized trees will enjoy full decoupling.
The unoptimized trees use the following modules:
We cannot decouple ToppleUpdate and SlowDeathBehavior from logic.
TODO