fix: Replace strcat with strlcat for robustness

[Skyaero42]

• Part of Replace strcpy, strncpy & co with strlcpy family functions #1518

This change replaces strcat with strlcat for robustness

TODO

• Replicate in Generals

[xezon]

Note that strlcpy, strlcat will have a tiny computational overhead over strcpy, strcat, for the benefit of stability. When touching hot code, such as AsciiString, UnicodeString, be extra mindful about it.

Generally, prefer using ARRAY_SIZE(buffer) instead of sizeof(buffer) or BUFFER_SIZE_VALUE. Because ARRAY_SIZE(buffer) works for both char* and wchar_t* and adapts without touching when the actual buffer changes.

Examples:

wchar_t buffer[123];
wcslcpy(buffer, src, sizeof(buffer)); // <---- wrong! sizeof(buffer) is too large and allows buffer overflow: better ARRAY_SIZE(buffer)

char buffer[MAX_PATH];
strlcpy(buffer, src, MAX_PATH); // <---- correct, but needs to be kept in sync with declaration: better ARRAY_SIZE(buffer)

[Skyaero42]

I don't understand why it doesn't compile VC6. Works fine on my PC.

[xezon]

Try change return(bool(value)); to return (bool)value;

[xezon]

Needs to be replicated to Generals.

[Skyaero42]

Rebased and replicated in generals