feat(scriptcompiler): add standalone SCB JSON converter#1856
Closed
bobtista wants to merge 11 commits intoTheSuperHackers:mainfrom
Closed
feat(scriptcompiler): add standalone SCB JSON converter#1856bobtista wants to merge 11 commits intoTheSuperHackers:mainfrom
bobtista wants to merge 11 commits intoTheSuperHackers:mainfrom
Conversation
|
The first observation is that the tool is decoupled from engine. Changing format in Engine will break the tool, unless changes are replicated to tool. |
Author
That's true. The point of that is so it's cross platform now. Some ideas:
|
1542dfd to
6c3dc9f
Compare
6c3dc9f to
907e606
Compare
Author
|
Ok I watched your stream, we can close this for now - but some day I hope to re-open it when we go cross platform :) |
|
I think I was not too happy talking about this :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
DataChunk Library
Core/Libraries/Source/DataChunk/Notes
Testing (done)