refactor: Remove all explicit AsciiString instantiations from C strings

[xezon]

• Addresses Remove unnecessary explicit AsciiString or UnicodeString instantiation #1777

This change removes all explicit AsciiString instantiations from C strings. It was applied with a script.

Risk should be low.

A risk from a refactor like this would be if a string pointer would be now compared.

const char* string;
if (string == AsciiString("Hello"))

to

const char* string;
if (string == "Hello")

But I reviewed all changes and there were only 2 comparisons and both of them are ok, comparing against an AsciiString.

This change does cut a lot of superfluous AsciiString allocations when no longer creating AsciiString from C string when calling into TheNameKeyGenerator->nameToKey, because that function needs no AsciiString to work.

UnicodeString needed no touching. No more occurences were found.

[Skyaero42]

I reviewed Generals and core. I pressume GeneralsMD is the same. Comments in Generals also apply to GeneralsMD

[Skyaero42]

Well done