feat(movie): Implement ESC button mapping to skip Campaign, Challenge and Score videos#1926
Merged
xezon merged 2 commits intoTheSuperHackers:mainfrom Dec 3, 2025
Merged
Conversation
Author
|
This needs another revision. |
3ca2ff3 to
02cb634
Compare
Author
|
Revised. I noticed there is also a movie playback in Score Screen, which apparently is used for End of Campaign videos. I made some changes to Keyboard class to allow consume raw keys from there. Tested in Campaign and Challenge. Worked. |
xezon
commented
Nov 30, 2025
xezon
commented
Nov 30, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp
Outdated
Show resolved
Hide resolved
1cbf8e4 to
5534024
Compare
Skyaero42
approved these changes
Dec 1, 2025
Skyaero42
left a comment
There was a problem hiding this comment.
The generals campaign video was also a loading screen. Does it work with that as well?
Author
|
I do not understand the question. Is that unique to Generals? |
5534024 to
6b7c19f
Compare
Author
|
Replicated in Generals with minor conflicts |
…pressed keys (#1926)
… and Score videos (#1926)
6b7c19f to
5bccbc9
Compare
I'll answer my own question, the 'satellite' video at the start of Generals missions are indeed skipable now. |
xezon
added a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change implements a ESC button mapping to skip Campaign, Challenge and Score videos.
TODO