-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Migrate diff-match-patch to a modern fork #9511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2450.1 KB |
| PR | 2448.2 KB |
Diff: ⬇️ Decrease: 1.9 KB
✅ Change Note Status
All change notes are properly formatted and validated!
⚠️ Impact: $:/changenotes/5.4.0/#9511/impacts/api
Impact Type: compatibility-break
Related Change: $:/changenotes/5.4.0/#9511
The diff-match-patch-es library uses different APIs
📝 $:/changenotes/5.4.0/#9511
Type: enhancement | Category: developer
Release: 5.4.0
Migrate diff-match-patch library to diff-match-patch-es
🔗 #9511
👥 Contributors: Leilei332
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
|
Do we have tests for diff-match-patch? |
The original respository does have tests. IMO it's up to the library author to test the library. For tiddlywiki, we may add tests for |
|
The current preview https://tiddlywiki.com/prerelease/#DiffTextWidget |
|
There is the https://deploy-preview-9511--tiddlywiki-previews.netlify.app/#makepatches%20and%20applypatches%20Operator%20(Examples) tiddler. If we could convert the examples to testcase widgets at tw-com, they will be picked up by our test runner. So we can have both. New test, that also work as documentation. |
|
Thank you @Leilei332. I think that this is a worthwhile change. It's hard to assess the backwards compatibility impact, but any errors it raises should be simple to diagnose. Having said that it would be helpful if we had an automated way to scan publicly published plugins. |

Important
This PR is not backward compatible due to API changes
The original diff-match-patch repository is now archived. This PR migrates it to diff-match-patch-es which is more modern and uses pure functions instead of one object.