Skip to content

Conversation

@peteratkins
Copy link
Contributor

Signing CLA


Submitted using https://edit.tiddlywiki.com/.

@netlify
Copy link

netlify bot commented Dec 29, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit f08b74c
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/695a6b86681ca500081bcaf0
😎 Deploy Preview https://deploy-preview-9534--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Dec 29, 2025

✅ Change Note Status

This PR contains documentation or configuration changes that typically don't require a change note.



@wiki-tutor, 2025/12/28
@wiki-tutor, 2025/12/28
Copy link
Member

@pmario pmario Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be 1 empty line between wiki-tutor and your signature, otherwise it will cause problems

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intermittently crops up with CLA signatures created by the PR maker edition but I haven't been able to figure out a pattern to it. Any thoughts @pmario ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm ... Is there a global git setting, that git commits or PRs are able to "trim" trailing new-line characters if they are at the end of the line. IMO some *nix editors do that by default.

Does the API, that you use to create PRs or commits have such a setting?

Just guessing ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the PR-maker create

signature
<extra newline>

or

<new-line>
signature

If the former is the case, auto-trimming at file-end may be a problem

@Jermolene
Copy link
Member

Thanks @peteratkins and welcome to the project.

@Jermolene Jermolene merged commit 7fb8560 into TiddlyWiki:tiddlywiki-com Jan 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants