-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Signing CLA #9534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing CLA #9534
Conversation
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Change Note StatusThis PR contains documentation or configuration changes that typically don't require a change note. |
|
|
||
|
|
||
| @wiki-tutor, 2025/12/28 | ||
| @wiki-tutor, 2025/12/28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be 1 empty line between wiki-tutor and your signature, otherwise it will cause problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This intermittently crops up with CLA signatures created by the PR maker edition but I haven't been able to figure out a pattern to it. Any thoughts @pmario ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm ... Is there a global git setting, that git commits or PRs are able to "trim" trailing new-line characters if they are at the end of the line. IMO some *nix editors do that by default.
Does the API, that you use to create PRs or commits have such a setting?
Just guessing ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the PR-maker create
signature
<extra newline>
or
<new-line>
signature
If the former is the case, auto-trimming at file-end may be a problem
|
Thanks @peteratkins and welcome to the project. |
Signing CLA
Submitted using https://edit.tiddlywiki.com/.