Skip to content

Signing CLA #9534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jermolene merged 2 commits into from
Jan 4, 2026
Merged

Signing CLA #9534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
143743f
Signing CLA
peteratkins Dec 29, 2025
f08b74c
Merge branch 'tiddlywiki-com' into Signing-CLA-20251229091151976
Jermolene Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions licenses/cla-individual.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,4 +640,8 @@ Rishu kumar, @rishu-7549, 2025/10/25

@wiki-tutor, 2025/12/28

@wiki-tutor, 2025/12/28
Copy link
Member

@pmario pmario Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be 1 empty line between wiki-tutor and your signature, otherwise it will cause problems

Copy link
Member

@saqimtiaz saqimtiaz Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intermittently crops up with CLA signatures created by the PR maker edition but I haven't been able to figure out a pattern to it. Any thoughts @pmario ?

Copy link
Member

@pmario pmario Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm ... Is there a global git setting, that git commits or PRs are able to "trim" trailing new-line characters if they are at the end of the line. IMO some *nix editors do that by default.

Does the API, that you use to create PRs or commits have such a setting?

Just guessing ...

Copy link
Member

@pmario pmario Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the PR-maker create

signature
<extra newline>

or

<new-line>
signature

If the former is the case, auto-trimming at file-end may be a problem


@peteratkins, 2025/12/29

@hsteve11, 2025/12/30