Skip to content

Feat/allerrors#39

Open
Tieske wants to merge 9 commits intomasterfrom
feat/allerrors
Open

Feat/allerrors#39
Tieske wants to merge 9 commits intomasterfrom
feat/allerrors

Conversation

@Tieske
Copy link
Owner

@Tieske Tieske commented Nov 29, 2025

replaces #37

@Tieske
Copy link
Owner Author

Tieske commented Nov 30, 2025

@houmkh @zhikai-kong I rebased #37 on master to fix CI, and then added some fixes and docs.

I haven't really reviewed the paths that are returned. Is this work complete for me to review?

@houmkh
Copy link

houmkh commented Dec 1, 2025

@houmkh @zhikai-kong I rebased #37 on master to fix CI, and then added some fixes and docs.

I haven't really reviewed the paths that are returned. Is this work complete for me to review?

Hi @Tieske thank you for your help! There might be some more changes. Let me check. When I'm ready, Could I mention you in #37 ?

@Tieske
Copy link
Owner Author

Tieske commented Dec 1, 2025

@houmkh probably better to close #37, and create a new PR on top of this (#39) one

@Tieske
Copy link
Owner Author

Tieske commented Dec 28, 2025

@houmkh any updates?

@houmkh
Copy link

houmkh commented Dec 29, 2025

Hi, @Tieske, sorry for the late, I will create a new PR these days.

@Tieske
Copy link
Owner Author

Tieske commented Feb 12, 2026

Ping

@houmkh
Copy link

houmkh commented Feb 13, 2026

Hi, @Tieske, sorry for the late, I will create a new PR these days.

Pong. Hi Tieske. After checking, I think this PR is LGTM.

@Tieske
Copy link
Owner Author

Tieske commented Feb 13, 2026

@copilot review the PR, especially focus on the paths returned, as mentioned in this comment: #39 (comment)

Copy link

Copilot AI commented Feb 13, 2026

@Tieske I've opened a new pull request, #40, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants