Review and document path generation in collect_all_errors feature#40
Draft
Copilot wants to merge 2 commits intofeat/allerrorsfrom
Draft
Review and document path generation in collect_all_errors feature#40Copilot wants to merge 2 commits intofeat/allerrorsfrom
Copilot wants to merge 2 commits intofeat/allerrorsfrom
Conversation
Open
Co-authored-by: Tieske <1077043+Tieske@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix all error handling in code
Review and document path generation in collect_all_errors feature
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed path generation for
schema_pathandinstance_pathin thecollect_all_errorsfeature per maintainer request. Implementation is correct with intentional design choices.Changes
/minLength,/maxLength, or/pattern) instead of empty schema_pathi-1(0-based JSON Pointer format) while error paths usei(1-based Lua indexing)instance_pathforadditionalPropertieserrors is intentional (refers to the object, not a specific property)Path Format
This deviates from JSON Pointer (RFC 6901) but aligns with Lua's native arrays, improving error message clarity for the target audience.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.