-
Notifications
You must be signed in to change notification settings - Fork 36
Expose overwrite parameter for saving a profile
#2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
overwrite parameter for saving a profile
overwrite parameter for saving a profileoverwrite parameter for saving a profile
|
Core 2.30 needs to be released before this is merged. |
jdblischak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a manual run of this PR branch against the 2.30.0-rc0 release binary in https://github.com/TileDB-Inc/centralized-tiledb-nightlies/actions/runs/19649300924. The tests passed!
overwrite parameter for saving a profileoverwrite parameter for saving a profile
|
Making the code conditional makes it mergeable right now. |
| else: | ||
| if overwrite: | ||
| raise lt.TileDBError( | ||
| "The 'overwrite' parameter is only supported in TileDB 2.30.0 and later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the TileDB-Py version
Following TileDB-Inc/TileDB#5695, this PR exposes the overwrite parameter for saving a profile introduced in TileDB Core 2.30.0.
Closes CORE-434
cc. @jdblischak