-
Notifications
You must be signed in to change notification settings - Fork 202
feat: add tiledb_query_add_predicate API to parse a SQL expression string into a QueryCondition
#5566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rroelke
wants to merge
56
commits into
main
Choose a base branch
from
rr/core-25-add-predicate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,437
−1,377
Open
feat: add tiledb_query_add_predicate API to parse a SQL expression string into a QueryCondition
#5566
Changes from 7 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
94eeeff
tiledb_query_add_predicate
rroelke ad3f43c
Remove assert post rebase
rroelke c10ef48
Fill in WHERE a IS NOT NULL example
rroelke 6017582
Fill in other global order unit test examples
rroelke 303e831
unit-query-add-predicate.cc tests for other readers
rroelke 7aaedd5
Move datafusion session to query instead of ContextResources
rroelke 3668cda
Tweak example comment
rroelke 4e2eebf
Enumeration::create const std::vector
rroelke bd16e7b
Tweak example
rroelke 40cb894
cpp example
rroelke 2139297
clippy
rroelke f10d157
Add test on evolved schema
rroelke 2b72ba4
Change test names
rroelke 1d962ec
Fix non-rust build
rroelke b0d36d3
Fix osx build errors
rroelke f246bd7
Fix C API example print_elem buffer
rroelke 744728d
Comment new/updated test support functions
rroelke bead919
Remove unnecessary ExternType impl
rroelke 02fb0ca
Self-review code comments
rroelke ec829e0
Attempt to fix query_add_predicate error
rroelke f2ddb4b
Undo clang-format-17 string splits
rroelke 176a021
Change C++ API to use std::string
rroelke d1c7680
Remove logger_->status
rroelke 653c890
SQL dialect in API comments
rroelke a00301c
Query add predicate to in progress query
rroelke be32216
Fix bizarre -Warray-bounds error for b_data_offsets
rroelke 763a3e2
Query add predicate with query condition
rroelke 1ab697f
Add tests demonstrating field escaping
rroelke 2c05e33
Add some FFI for sm Buffer
rroelke 666e138
FFI use_enumeration
rroelke 069162b
Bindings for accessing enumeration contents and locating them in a sc…
rroelke 9758e7f
ArrowSchema => ArrowArraySchema, contains dyn ArrowArray for enumerat…
rroelke b41d1aa
Move definitions to .cc file to avoid multiple definition error
rroelke d78e434
Add WhichSchema to distinguish schema for view vs. storage, passes un…
rroelke 860d3d5
Fix wrong write size in unit_query_condition.cc
rroelke 9d8e4ff
Fix UTF-8, unit_query_condition passes
rroelke d6889bd
Stopgap for enumerations in WhichSchema::View
rroelke d5caf2c
clippy
rroelke 314b169
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke 9046ef1
RestClientFactory can construct in place
rroelke 33c8a72
Handle TILEDB_RUST=OFF in unit-query-add-predicate.cc
rroelke a3e6617
HeapMemoryLinter ignores oxidize dir
rroelke e18ccd7
Fix empty dimension tuple
rroelke f1d7eb5
make format
rroelke 27a1be3
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke 572ba80
Remove non-experimental version of add_predicate
rroelke 0edb237
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke 77c0f85
Merge remote-tracking branch 'origin/main' into rr/core-25-add-predicate
rroelke 1823e8a
Fix error message grammar
rroelke c242c16
Split no predicate and WHERE TRUE in examples
rroelke d8eb419
cargo update and remove cxxbridge version pin
rroelke 66ff1fc
Single QueryPredicates FFI boundary compiles, not tested
rroelke 5d2521e
Single QueryPredicates FFI boundary passes existing tests
rroelke 48195cf
unit_query_condition and API test both pass
rroelke 6f7d080
self review
rroelke 199ea2f
clippy
rroelke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt that an example in C is useful to have. As I have said in the past, the C API is hard to use directly, and users should prefer using a higher-level language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the C examples are useful for developers, if not customers (who I agree are better off using higher-level APIs). I have referred to them often.