Feat: Joiners contains and containedIn #972
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces new specialized Joiners (contain, containedIn, and containAny) to replace generic filtering joiners in the conference scheduling constraint provider, improving code readability and expressiveness while maintaining semantic equivalence.
Changes:
- Replaced individual Joiners static imports with a wildcard import
- Refactored 10 constraint methods to use new specialized joiners instead of
filteringlambdas - Maintained all existing penalty calculations and scoring logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import static ai.timefold.solver.core.api.score.stream.Joiners.greaterThan; | ||
| import static ai.timefold.solver.core.api.score.stream.Joiners.lessThan; | ||
| import static ai.timefold.solver.core.api.score.stream.Joiners.overlapping; | ||
| import static ai.timefold.solver.core.api.score.stream.Joiners.*; |
There was a problem hiding this comment.
Wildcard static imports can reduce code clarity and IDE support. Consider using explicit imports for each Joiner method (equal, greaterThan, lessThan, overlapping, filtering, contain, containedIn, containAny) to improve code maintainability and make dependencies more explicit.
| import static ai.timefold.solver.core.api.score.stream.Joiners.*; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.equal; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.greaterThan; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.lessThan; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.overlapping; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.filtering; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.contain; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.containedIn; | |
| import static ai.timefold.solver.core.api.score.stream.Joiners.containAny; |
| .join(Speaker.class, | ||
| filtering((talk, speaker) -> talk.hasSpeaker(speaker) | ||
| && speaker.getUnavailableTimeslots().contains(talk.getTimeslot()))) | ||
| contain(Talk::getSpeakers, speaker -> speaker), |
There was a problem hiding this comment.
The lambda expression speaker -> speaker is an identity function. Depending on the API design, this could potentially be simplified to a method reference or omitted if the API supports it. Verify if the Joiners API provides a simpler alternative for identity mapping.
2 participants
Uh oh!
There was an error while loading. Please reload this page.