Typed logging #624
Merged
Typed logging #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the progress and reachability logs to typed logs, which do not require casting at runtime. Signed-off-by: Moritz Hoffmann <[email protected]>
frankmcsherry
approved these changes
Jan 17, 2025
Member
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
This looks pretty good to me; no notes.
antiguru
commented
Jan 17, 2025
Comment on lines
+137
to
+138
| let mut messages = Vec::with_capacity(changes.len()); | ||
| let mut internal = Vec::with_capacity(changes.len()); |
Member
Author
There was a problem hiding this comment.
Note that we should be using recv_changes.len() here, because changes doesn't have any relation to what we're receiving. But, then we'd over-allocate :/
Member
There was a problem hiding this comment.
Ah, could you explain that more? I agree that recv_changes.len() looks more appropriate, but what is the downside (seems like we fill these up with exactly that many elements, and then ship them in the TimelyProgressEvent)?
Member
There was a problem hiding this comment.
Ah, because we have to demux the two types of events, probably?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the progress and reachability logs to typed logs, which do not require casting at runtime.
The loggers are accessible using new names:
timely/progress->timely/progress/with the type name appended.timely/reachability->timely/reachability/with the type name appended.It's using
std::any::type_name()to determine a unique string for the timestamp type.Analyzing
logging-sendfor allocations, this roughly cuts down total allocations in half.target/release/examples/logging-send 1000 1000 -w4produces roughly 850k allocations in current master, and 445k on this branch.