-
-
Notifications
You must be signed in to change notification settings - Fork 9
refactor: update profile constants and enhance recommendation logic #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @TimilsinaBimal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the recommendation system by updating various profile constants and enhancing the core recommendation logic. The changes aim to improve the quality, diversity, and performance of "Top Picks" recommendations by refining how items are sampled, scored, and filtered, leading to a more relevant and balanced user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the recommendation logic by updating various constants and enhancing the scoring and candidate generation process. The changes simplify the quality adjustment scoring and introduce a more sophisticated candidate sourcing strategy. Overall, the direction is positive, but there are several issues to address. These include a bug in the sampling logic, a potential logic error in sorting by popularity, and the final recommendation list not being trimmed to the requested limit. Additionally, there are opportunities to improve code quality by removing unused parameters, moving imports to the top level, and cleaning up some inconsistencies in comments and docstrings.
…y_discover and random shuffle option
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new catalog configuration options, display_at_home and shuffle, allowing users to control whether a catalog appears on the Stremio home screen and if its items should be randomized. The API endpoint for catalogs is updated to support an optional extra parameter for filtering. Several recommendation constants are adjusted, including RECENCY_HALF_LIFE_DAYS (from 90 to 15 days) and diversity caps for genres, creators, and eras, alongside changes to minimum vote counts and ratings for quality filtering. The scoring logic for recommendations is simplified by removing is_ranked and is_fresh parameters, and apply_quality_adjustments is refactored to use a simpler boost. The get_catalog service now shuffles items if configured, and get_top_picks has been optimized with pre-enrichment limiting and updated diversity cap logic, while removing the fetching of trending/popular candidates. The frontend is updated to support these new display_at_home and shuffle settings with new UI controls and improved styling for catalog management. Additionally, the frontend now includes persistent login functionality using local storage for both Stremio auth keys and email/password, along with a new user profile dropdown and logout buttons.
…proved code maintainability
…ce for improved clarity and error handling
…a shuffling logic in CatalogService
No description provided.