-
Notifications
You must be signed in to change notification settings - Fork 102
🆕 Improve Support for QuPath GeoJson and Multipoint Geometry
#841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TIAViz Review Comments
…toolbox into address-review-comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses reviewer feedback for the TIAViz paper by updating the overlay naming scheme, adding multipoint geometry rendering, and robustifying geojson importing for the qupath nucleusGeometry format.
- Renames static image overlay layers to the filename stem.
- Introduces multipoint geometry rendering in the tile renderer and adds associated tests.
- Enhances geojson import logic to handle qupath's nucleusGeometry.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tiatoolbox/visualization/tileserver.py | Uses the file stem for overlay layer naming instead of a generic index. |
| tiatoolbox/visualization/bokeh_app/main.py | Adjusts slider and alpha mappings to use the new naming scheme. |
| tiatoolbox/utils/visualization.py | Adds multipoint geometry rendering methods and updates rendering logic. |
| tiatoolbox/tools/pyramid.py | Minor update: adds type import for Literal. |
| tiatoolbox/annotation/storage.py | Incorporates qupath's nucleusGeometry into the geojson transformation. |
| tests/test_tileserver.py | Updates tests for overlay naming consistency. |
| tests/test_app_bokeh.py | Updates slider tests to reflect the new naming convention. |
| tests/test_annotation_tilerendering.py | Adds tests for multipoint geometry rendering. |
Comments suppressed due to low confidence (2)
tiatoolbox/visualization/tileserver.py:516
- Ensure that deriving overlay layer names solely from file stems does not lead to naming conflicts if multiple overlays share the same filename stem. Consider appending an index or unique identifier if duplicates may occur.
layer = overlay_path.stem
tiatoolbox/utils/visualization.py:856
- Replacing self.thickness with -1 in the cv2.circle call forces a filled circle, which may bypass intended thickness settings. Verify that this change produces the expected visual output for point annotations.
thickness=-1,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @measty It looks good to me.
I have added a few comments and there are some conflicts to resolve before we merge.
TIAViz Review CommentsQuPath GeoJson and Multipoint Geometry
…ageAnalytics/tiatoolbox into address-review-comments
…toolbox into address-review-comments
for more information, see https://pre-commit.ci
…ageAnalytics/tiatoolbox into address-review-comments
I've addressed the comments and the conflict, looks like I still need to add a test though |
…toolbox into address-review-comments
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ageAnalytics/tiatoolbox into address-review-comments
shaneahmed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @measty This looks good.
This PR makes a collection of changes related to reviewer comments in the TIAViz paper.
Main changes are:
nucleusGeometry.