Skip to content

hermes v1導入#5471

Merged
TinyKitten merged 2 commits intodevfrom
feature/hermes-v1
Feb 27, 2026
Merged

hermes v1導入#5471
TinyKitten merged 2 commits intodevfrom
feature/hermes-v1

Conversation

@TinyKitten
Copy link
Member

@TinyKitten TinyKitten commented Feb 27, 2026

Summary by CodeRabbit

リリースノート

  • New Features

    • ビルド設定に新しいビルドプロパティを導入し、React Native をソースからビルドできるオプションとHermes V1の利用を有効化しました。
  • Chores

    • 開発向けAndroidビルドの実行コマンドをデバッグ向けのバリアントに変更しました(devDebug)。
    • Hermes関連のツールバージョン上書きを追加しました。

@TinyKitten TinyKitten self-assigned this Feb 27, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69c4ee4 and 3c4f995.

📒 Files selected for processing (1)
  • app.config.ts

📝 Walkthrough

Walkthrough

Expoの設定とpackage.jsonが更新され、expo-build-propertiesプラグインが追加され(buildReactNativeFromSource:true, useHermesV1:true)、Androidの実行スクリプトに--variant devDebugが追加され、Hermesコンパイラのオーバーライドが追記されました。

変更内容

コホート / ファイル(s) 概要
Expoプラグイン構成
app.config.ts
expo-build-propertiesプラグインを追加(buildReactNativeFromSource: true, useHermesV1: true)。既存のexpo-location関連プラグイン配列に入れ子のブロックと重複に見えるexpo-assetエントリを挿入。
ビルドスクリプトと依存関係
package.json
"android"スクリプトをexpo run:android -- --variant devDebugに変更。expo-build-properties依存を追加。overrideshermes-compiler: "250829098.0.4"を追加。

推定コードレビュー時間

🎯 3 (Moderate) | ⏱️ ~20 minutes

関連する可能性のあるPR

推奨ラベル

android

🐇 小さなウサギが跳ねるよ、
プラグイン増えてコードが歌う、
Hermesを抱いてビルドは進む、
devDebugで新しい風、
ピョンと成功へ! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR タイトル「hermes v1導入」は、変更内容の主要な目的(Hermes V1 の導入)を正確かつ簡潔に表しており、expo-build-properties の追加と設定の変更を反映しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/hermes-v1

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
package.json (1)

39-39: 依存関係追加後の検証を推奨します。

Based on learnings: 依存関係のアップグレード後は expo-doctornpm run lintnpm testnpm run typecheck を実行し、結果を確認してください。

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 39, You added the "expo-build-properties" dependency;
verify the upgrade by running the recommended validation commands locally and in
CI: run expo-doctor, npm run lint, npm test, and npm run typecheck, fix any
reported issues, update lockfiles (e.g., package-lock.json or yarn.lock) and
commit the changes, and if your repository has CI workflows (e.g., GitHub
Actions) ensure those scripts are executed there as well so regressions from
"expo-build-properties" are caught automatically.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app.config.ts`:
- Line 14: app.config.ts に同じプラグイン 'expo-build-properties'
が重複しているので、トップレベルで単純な文字列として登録されている 'expo-build-properties'
のエントリを削除し、設定付きのプラグイン定義(現在の Lines 39-45 にあるオブジェクト形式のエントリ)だけを残してください;
buildReactNativeFromSource と useHermesV1 はトップレベルのままで問題ないため変更不要です。

---

Nitpick comments:
In `@package.json`:
- Line 39: You added the "expo-build-properties" dependency; verify the upgrade
by running the recommended validation commands locally and in CI: run
expo-doctor, npm run lint, npm test, and npm run typecheck, fix any reported
issues, update lockfiles (e.g., package-lock.json or yarn.lock) and commit the
changes, and if your repository has CI workflows (e.g., GitHub Actions) ensure
those scripts are executed there as well so regressions from
"expo-build-properties" are caught automatically.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e47567 and 69c4ee4.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • app.config.ts
  • package.json

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@TinyKitten TinyKitten merged commit c799fb2 into dev Feb 27, 2026
4 checks passed
@TinyKitten TinyKitten deleted the feature/hermes-v1 branch February 27, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant