Remove stale and UB winapi compatibility layer
#256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper-Bekkers
approved these changes
Dec 10, 2024
Member
Author
|
Yikes this new presser code is triggering some new clippy lints... and as far as I remember didn't even resolve our original soundness issues 😅 |
Jasper-Bekkers
approved these changes
Jan 24, 2025
Member
Author
|
@Jasper-Bekkers in order to merge this, we must remove the branch-protection rules that expect a check with |
MarijnS95
force-pushed
the
rm-winapi
branch
2 times, most recently
from
723eff5 to
b0d15c6
Compare
Merged
Jasper-Bekkers
approved these changes
May 29, 2025
Member
Jasper-Bekkers
left a comment
Jasper-Bekkers
left a comment
There was a problem hiding this comment.
Removed the rules! Nice to see this change!
With the `windows` migration we introduced a `winapi` compatibility layer to make it easier to use `winapi` types with `gpu-allocator`. As most of the ecosystem has switched to `windows` it is now time to sunset these helpers which are otherwise tedious to test and maintain, not to mention contain long(er) standing unsoundness bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255
With the
windowsmigration we introduced awinapicompatibility layer to make it easier to usewinapitypes withgpu-allocator. As most of the ecosystem has switched towindowsit is now time to sunset these helpers which are otherwise tedious to test and maintain, not to mention contain long(er) standing unsoundness bugs.