Merged
Conversation
3bf423b to
b0acb03
Compare
Abdulsametileri
approved these changes
Feb 11, 2026
emreodabas
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the project-wide Go version from 1.19 to 1.24 and updates all related tooling to ensure full compatibility. Also fixes a nil pointer dereference bug in
SetDefaults()that was exposed by Go 1.24's different goroutine scheduling behavior.Changes
Go Version Upgrade (10 files)
All
go.modfiles updated fromgo 1.19togo 1.24:go.modgo 1.19→go 1.24test/integration/go.modgo 1.19→go 1.24examples/single-consumer/go.modgo 1.19→go 1.24examples/single-consumer-with-deadletter/go.modgo 1.19→go 1.24examples/multiple-consumer/go.modgo 1.19→go 1.24examples/single-consumer-with-producer/go.modgo 1.19→go 1.24examples/single-consumer-with-custom-logger/go.modgo 1.19→go 1.24examples/single-consumer-with-metric-collector/go.modgo 1.19→go 1.24examples/single-consumer-with-backoff-strategy/go.modgo 1.19→go 1.24examples/single-consumer-with-header-filter-function/go.modgo 1.19→go 1.24GitHub Workflows (3 files)
actions/checkout:v3→v4actions/setup-go:v3→v4goreleaser-action:v4→v5golangci-lint-action:v3→v6go-version:1.19→1.24v1.51→v1.64.8golangci-lint Configuration (2 files)
golangci-lint v1.51 only supports up to Go 1.20. Updated to v1.64.8 (the last v1.x release with Go 1.24 support).
Makefilev1.51.0→v1.64.8.golangci.ymlserviceblock, removeddepguardlinter (requires explicit config in v1.64+)Bug Fix: Nil Logger Panic
Problem:
Config.SetDefaults()did not initialize theLoggerfield. In Go 1.19, tests completed before the cron job (@every 1s) fired, so the nil Logger was never accessed. Go 1.24's different goroutine scheduling caused the cron to fire during tests, triggering a nil pointer dereference atcronsumer_client.go:88.Fix:
pkg/kafka/config.go— Added automatic Logger initialization inSetDefaults()whenLogger == nilpkg/kafka/config_test.go— Updated assertion to verify Logger is initialized rather than expecting nilLint Fixes (2 files)
The newer golangci-lint version introduced stricter checks:
internal/cronsumer_test.gomessage→_,ctx→_, etc.)internal/cronsumer_client_test.gomessage→_)