fix: prevent compiling wasm only code on unsupported platforms#225
fix: prevent compiling wasm only code on unsupported platforms#225rtyler wants to merge 2 commits intoTrueLayer:mainfrom
Conversation
|
Publish dry run is failing, maybe all features are turned on? Reqwest removed this function completely: seanmonstar/reqwest@0bcba46 |
reqwest-middleware/src/client.rs
Outdated
| /// The [request mode][mdn] will be set to 'no-cors'. | ||
| /// | ||
| /// [mdn]: https://developer.mozilla.org/en-US/docs/Web/API/Request/mode | ||
| #[cfg(target_family = "wasm")] |
There was a problem hiding this comment.
reqwest uses this cfg attribute https://github.com/seanmonstar/reqwest/blob/master/src/lib.rs#L255C9-L255C39:
#[cfg(target_arch = "wasm32")]
I wonder if the issue is that these don't match
See also seanmonstar/reqwest#2596 Fixes TrueLayer#224 Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
rtyler
force-pushed
the
conditional-wasm
branch
from
2219899 to
a7597a7
Compare
|
@benbrandt should this PR be reviewed and obtained an approval from you for it to get merged? |
|
@douggynix I doubt it because I'm not a maintainer but I did anyway |
|
Can we include the maintainers in the comments to have this PR reviewed. I am having build errors which this PR has fixed. A review to update the library crate would be very useful for me and others experiencing build issues with the latest versions of reqwest. |
|
@eopb : would you have a look at this PR for approbation or change request please? |
Co-authored-by: Jonathan Donaldson <jon@than.dev>
|
@rtyler : you got pending requested changes to fix the CI issue. any update on this please? |
|
why this PR is still pending for so long knowing that there are build failures issues for the new versions of reqwest? |
|
Closing as this has now been fixed in reqwest-middleware 0.4.2 I didn't have permission to push changes to this branch, so I've fixed this in a separate PR: #230. |
5 participants
See also seanmonstar/reqwest#2596
Fixes #224