-
Notifications
You must be signed in to change notification settings - Fork 100
Update retry-policies to 0.5 #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f5da2ac
to
3f65b58
Compare
Would be a good idea to update the |
Heads up, there's a new version of retry-policies @musicinmybrain you could grab for this |
I think |
Could this be merged and released? This is currently blocking us to update some other dependencies as well. |
27e379a
to
26d50a7
Compare
(Rebased without changes.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this 💮
could you update the changelog in reqwest-retry
and remove the changelog changes in reqwest-middleware
? LGTM otherwise
The build_with_total_retry_duration_and_max_retries method of retry_policies::policies::ExponentialBackoffBuilder was renamed to build_with_total_retry_duration_and_limit_retries. No code changes are required, but since reqwest-retry re-exports retry-policies::policies as reqwest_retry::policies, this is a SemVer-breaking change for reqwest-retry as well.
26d50a7
to
e6a25eb
Compare
Thanks for noticing that! I moved the changelog entry to the correct crate and rebased on |
The
build_with_total_retry_duration_and_max_retries method
ofretry_policies::policies::ExponentialBackoffBuilder
was renamed tobuild_with_total_retry_duration_and_limit_retries
. No code changes are required, but sincereqwest-retry
re-exportsretry-policies::policies
asreqwest_retry::policies
, this is a SemVer-breaking change forreqwest-retry
as well.