Skip to content

Do not retry OpenMHz uploads for configuration errors#1070

Merged
robotastic merged 1 commit intoTrunkRecorder:masterfrom
taclane:openmhz-no-retry
Dec 13, 2025
Merged

Do not retry OpenMHz uploads for configuration errors#1070
robotastic merged 1 commit intoTrunkRecorder:masterfrom
taclane:openmhz-no-retry

Conversation

@taclane
Copy link
Contributor

@taclane taclane commented Nov 30, 2025

This addresses a bug where OpenMHz configuration errors (invalid API keys, incorrect system IDs, bad filenames, ignored talkgroups) will return a call to the retry queue instead of skipping and moving on.

In the event of an upload failure, the plugin will parse the reply from the server and compare it against a list of select errors that will not require further handling. All other errors (such as connection issues) will return the call to the retry queue.

This is a helpful change because the OpenMHz admin panel includes a configuration option for Ignore Unknown Talkgroups. Should that option be enabled, Trunk Recorder presently retries a call from an unknown talkgroup until it reaches the maximum number of attempts. The broadcastify plugin uses a similar form of error handling to determine that SKIPPED or REJECTED calls need not be reattempted.

Preventing these calls from being reattempted will reduce some load on the OpenMHz API, and ensure that temporary files on the local device are cleaned up without lingering another ~6 minutes until MAX_RETRY.

@Dygear
Copy link
Contributor

Dygear commented Dec 13, 2025

Clean, I like it.

@robotastic
Copy link
Collaborator

great call!!

@robotastic robotastic merged commit b589f77 into TrunkRecorder:master Dec 13, 2025
1 check passed
@taclane taclane deleted the openmhz-no-retry branch December 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants