Skip to content

Do not retry OpenMHz uploads for configuration errors #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robotastic merged 1 commit into from
Dec 13, 2025
Merged

Do not retry OpenMHz uploads for configuration errors #1070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions plugins/openmhz_uploader/openmhz_uploader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,27 @@ class Openmhz_Uploader : public Plugin_Api {
}
}
std::string loghdr = log_header(call_info.short_name,call_info.call_num,call_info.talkgroup_display,call_info.freq);

// Configuration errors - skip the retry queue
static const struct { const char* match; const char* message; bool is_error; } config_errors[] = {
{"API Keys do not match", "Error: Invalid API Key", true},
{"ShortName does not exist", "Error: Invalid System Name", true},
{"Error, invalid filename", "Error: Invalid Filename", true},
{"Talkgroup does not exist", "Skipped: System Ignoring Unknown Talkgroups", false}
};

for (const auto& error : config_errors) {
if (response_buffer.find(error.match) != std::string::npos) {
if (error.is_error) {
BOOST_LOG_TRIVIAL(error) << loghdr << "OpenMHz Upload " << error.message;
} else {
BOOST_LOG_TRIVIAL(info) << loghdr << "OpenMHz Upload " << error.message;
}
return 0;
}
}

// Default error - add to the retry queue
BOOST_LOG_TRIVIAL(error) << loghdr << "OpenMHz Upload Error: " << response_buffer;
return 1;
}
Expand Down
Loading