Adopt config:best-practices as Renovate base preset#11
Conversation
Switch the shared preset baseline from config:recommended to config:best-practices while preserving existing Ghost-specific behavior. Keep lockfile maintenance and minimum release age explicitly listed with comments so these safeguards remain visible and intentional.
WalkthroughThe Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
quiet.json5 (1)
5-6: Appropriate adoption ofconfig:best-practices.The
config:best-practicespreset includes the Renovate maintainers' upgrade best practices and extendsconfig:recommendedwith additional presets includingsecurity:minimumReleaseAgeNpmand:maintainLockFilesWeekly.Note:
config:best-practicesalready includes:pinDevDependencies, which is also explicitly listed at line 15. This redundancy is harmless (Renovate handles idempotent presets), but you may want to remove the explicit:pinDevDependenciesat line 15 for consistency—unless you intentionally keep it for visibility like the other two safeguards.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@quiet.json5` around lines 5 - 6, The config:best-practices preset already includes :pinDevDependencies, so in quiet.json5 remove the redundant explicit ":pinDevDependencies" entry to avoid duplication (or if you intended to keep it for visibility, add a comment explaining that choice); update the presets array to only list "config:best-practices" (and any other presets you intentionally want) and ensure the symbol ":pinDevDependencies" is not repeated elsewhere in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@quiet.json5`:
- Around line 5-6: The config:best-practices preset already includes
:pinDevDependencies, so in quiet.json5 remove the redundant explicit
":pinDevDependencies" entry to avoid duplication (or if you intended to keep it
for visibility, add a comment explaining that choice); update the presets array
to only list "config:best-practices" (and any other presets you intentionally
want) and ensure the symbol ":pinDevDependencies" is not repeated elsewhere in
the file.
|
LGTM 🎉 Since we'll be pinning GHA workflows now, is it worth adding an automerge rule for trusted (official/our own) GHA changes? Will keep noise lower I think. Happy to PR this myself. |
Summary
Why
This keeps Ghost-specific behavior while inheriting Renovate’s broader best-practice baseline and makes the two critical safety protections explicit and durable in our shared preset.