Add Aqua tests for automated quality assurance #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yebai 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Copilot
AI
changed the title
Aqua tests
Copilot finished work on behalf of
yebai
August 28, 2025 00:22
|
AbstractPPL.jl documentation for PR #130 is available at: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 86.28% 86.28%
=======================================
Files 5 5
Lines 401 401
=======================================
Hits 346 346
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 17282963650Details
💛 - Coveralls |
yebai
reviewed
Aug 28, 2025
test/runtests.jl
Outdated
| using Test | ||
|
|
||
| const GROUP = get(ENV, "GROUP", "All") | ||
| const AQUA = get(ENV, "AQUA", "true") == "true" |
There was a problem hiding this comment.
@copilot, remove the AQUA variable and relevant checks. Always run Aqua.jl in test groups All and Tests.
There was a problem hiding this comment.
Removed the AQUA environment variable and conditional checks. Aqua tests now always run in the "All" and "Tests" groups as requested. (c44ff27)
…ts groups Co-authored-by: yebai <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
yebai
August 28, 2025 01:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Aqua.jl tests to provide automated quality assurance for the AbstractPPL.jl package, similar to the implementation in DynamicPPL.jl (issue #758).
What's Added
test/Project.tomlwith proper compatibility constraintstest/Aqua.jlthat runs automated quality assurance teststest/runtests.jlto include Aqua tests in the "All" and "Tests" groupsQuality Checks Included
The Aqua tests check for common package quality issues:
Note: Ambiguity tests are currently excluded since they primarily catch issues from interactions with third-party packages rather than AbstractPPL itself.
Usage
The Aqua tests run automatically with the test suite:
This helps prevent quality issues like undefined exports and ensures consistent package maintenance standards across the TuringLang ecosystem.
Fixes #120.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.