Skip to content

Add Aqua tests for automated quality assurance #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2025
Merged

Add Aqua tests for automated quality assurance #130

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73f7114
Initial plan
Copilot Aug 28, 2025
b2df755
Add Aqua tests for automated quality assurance
Copilot Aug 28, 2025
1fd4ed4
Merge branch 'main' into copilot/fix-120
yebai Aug 28, 2025
8182dea
Fix missing newline at end of Aqua.jl
yebai Aug 28, 2025
c44ff27
Remove AQUA environment variable and always run Aqua tests in All/Tes…
Copilot Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/Aqua.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module AquaTests

using Aqua: Aqua
using AbstractPPL

# For now, we skip ambiguities since they come from interactions
# with third-party packages rather than issues in AbstractPPL itself
Aqua.test_all(AbstractPPL; ambiguities=false)

end
2 changes: 2 additions & 0 deletions test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[deps]
Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
InvertedIndices = "41ab1584-1d38-5bbf-9106-f11c6c58b48f"
Expand All @@ -10,6 +11,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[compat]
Accessors = "0.1"
Aqua = "0.8"
Distributions = "0.25"
Documenter = "0.26.3, 0.27, 1"
InvertedIndices = "1"
Expand Down
4 changes: 4 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ using Documenter
using Test

const GROUP = get(ENV, "GROUP", "All")
const AQUA = get(ENV, "AQUA", "true") == "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot, remove the AQUA variable and relevant checks. Always run Aqua.jl in test groups All and Tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the AQUA environment variable and conditional checks. Aqua tests now always run in the "All" and "Tests" groups as requested. (c44ff27)


@testset "AbstractPPL.jl" begin
if GROUP == "All" || GROUP == "Tests"
if AQUA
include("Aqua.jl")
end
include("varname.jl")
include("abstractprobprog.jl")
include("hasvalue.jl")
Expand Down
Loading