-
Notifications
You must be signed in to change notification settings - Fork 8
bump versions, update AD tests, update workflows #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
b59ab17
a13bc6e
2a037c1
f305264
630bc6e
96a0e1b
bd03def
2d5eac5
a538257
69c726a
ce483e4
fac5c4a
2ae3417
b7e5ffb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
name = "TuringGLM" | ||
uuid = "0004c1f4-53c5-4d43-a221-a1dac6cf6b74" | ||
authors = ["Jose Storopoli <[email protected]>", "Rik Huijzer <[email protected]>", "contributors"] | ||
version = "2.13.0" | ||
version = "2.13.1" | ||
storopoli marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
[deps] | ||
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f" | ||
|
@@ -29,5 +29,5 @@ StatsBase = "0.33 - 0.34" | |
StatsModels = "0.6.28 - 0.7" | ||
TableOperations = "1.2" | ||
Tables = "1.6" | ||
Turing = "0.20 - 0.37" | ||
Turing = "0.20 - 0.39" | ||
julia = "1" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,6 @@ | |
[](https://TuringLang.github.io/TuringGLM.jl/stable) | ||
[](https://TuringLang.github.io/TuringGLM.jl/dev) | ||
[](https://github.com/TuringLang/TuringGLM.jl/actions/workflows/CI.yml?query=branch%3Amain) | ||
[](https://codecov.io/gh/TuringLang/TuringGLM.jl) | ||
[](https://coveralls.io/github/TuringLang/TuringGLM.jl?branch=main) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we not using these badges anymore in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think Turing.jl still has the coverage badges, but coverage isn't enabled for TuringGLM (https://github.com/TuringLang/TuringGLM.jl/blob/main/.github/workflows/CI.yml) so AFAIK this is not being updated (the badges currently displayed in the main readme has codecov @ 74% pointing to a commit from a while ago, and coveralls says unknown). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, not blocking, but you can try to re-enable it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmmm, let me try to copy the config over from another repo. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If it works you can add the badges back |
||
[](https://github.com/invenia/BlueStyle) | ||
penelopeysm marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
[](https://github.com/SciML/ColPrac) | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,20 @@ | ||
@timed_testset "ad_backends" begin | ||
using ForwardDiff: ForwardDiff | ||
using ReverseDiff: ReverseDiff | ||
using Mooncake: Mooncake | ||
|
||
@timed_testset "ad_backends.jl" begin | ||
DATA_DIR = joinpath("..", "data") | ||
cheese = CSV.read(joinpath(DATA_DIR, "cheese.csv"), DataFrame) | ||
f = @formula(y ~ (1 | cheese) + background) | ||
m = turing_model(f, cheese) | ||
# only running 2 samples to test if the different ADs runs | ||
@timed_testset "ForwardDiff" begin | ||
chn = sample(m, NUTS(; adtype=AutoForwardDiff(; chunksize=8)), 2) | ||
@test chn isa Chains | ||
end | ||
# TODO: fix Tracker tests | ||
# @timed_testset "Tracker" begin | ||
# using Tracker | ||
# chn = sample(m, NUTS(; adtype=AutoTracker()), 2) | ||
# @test chn isa Chains | ||
# end | ||
# TODO: fix Zygote tests | ||
# @timed_testset "Zygote" begin | ||
# using Zygote | ||
# chn = sample(m, NUTS(; adtype=AutoZygote()), 2) | ||
# @test chn isa Chains | ||
# end | ||
@timed_testset "ReverseDiff" begin | ||
using ReverseDiff | ||
chn = sample(m, NUTS(; adtype=AutoReverseDiff(; compile=true)), 2) | ||
@test chn isa Chains | ||
|
||
ADTYPES = [ | ||
AutoForwardDiff(), | ||
AutoReverseDiff(; compile=false), | ||
AutoReverseDiff(; compile=true), | ||
AutoMooncake(; config=nothing), | ||
] | ||
@testset "$adtype" for adtype in ADTYPES | ||
@test sample(m, NUTS(; adtype=adtype), 20) isa Chains | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is '1.10' covered by '1'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh LTS is 1.10 and
1
is1.11
gotcha.